Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox integration with gnome nautilus 43.2.1 is no longer working. Your latest fix (nominal version 2022.12.05 Fedora 37) for gnome 43 is no longer working as well. #114

Closed
voedev opened this issue Jan 10, 2023 · 5 comments

Comments

@voedev
Copy link

voedev commented Jan 10, 2023

Installed the new version of dropbox for fedora 37, everything was working and the checkmark icon was showing successfully. But yesterday a new gnome nautilus update 43.2.1 came out and now the integration with nautilus is broken again. Reinstalling the app doesn't help.

screen

@velsinki
Copy link

velsinki commented Jan 11, 2023

Same problem here. It seems to be related to the emblem path finding, because the "shared" emblem is still displayed (which is built-in?).

@voedev voedev changed the title Dropbox stopped working with gnome nautilus 43.2.1 on fedora 37, your fix doesn't work Dropbox integration with gnome nautilus 43.2.1 is no longer working. Your latest fix (nominal version 2022.12.05 Fedora 37) for gnome 43 is no longer working as well. Jan 12, 2023
@velsinki
Copy link

I have digged a bit deeper, and I think I have found the root cause. It's likely incorrect behavior on the part of nautilus, although Dropbox is also partially to blame for not putting the emblems inside the hicolor theme.

I have reported it here: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2789

@velsinki
Copy link

I think it might be quite difficult to fix this in nautilus itself, unless they revert that commit.
For now, an easy fix is:

cd ~/.dropbox-dist/dropbox-*/images/emblems
mkdir -p hicolor/64x64/emblems && cp *.* $_

This basically sets up the correct folder structure for the emblems to be added to the fallback hicolor theme, so that nautilus will think they exist properly.

@velsinki
Copy link

With my workaround above, and with

Nautilus workaround: https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/1174
My GTK fix: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5865

I think this issue can be closed. Those fixes should eventually land in distros.

A quicker fix would be if Dropbox packages their emblems in the hicolor theme to begin with (like in my "fix" above), but I don't think that'll happen (@goffrie ?).

@voedev voedev closed this as completed May 11, 2023
@goffrie
Copy link
Contributor

goffrie commented May 23, 2023

@velsinki Thanks for your work upstream. Indeed Nautilus 43.4 (which is now in Fedora 37 updates) includes your fix and resolves the issue.
For v176 of the client I'll move our emblems into hicolor as that appears to work on all Nautilus versions and seems "more correct" if I understand correctly.

Thanks everyone for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants