Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fetch from auth #929

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Use fetch from auth #929

merged 3 commits into from
Apr 4, 2022

Conversation

rogebrd
Copy link
Contributor

@rogebrd rogebrd commented Mar 31, 2022

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does npm test pass?
  • Does npm run build pass?
  • Does npm run lint pass?

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #929 (f1aa5d0) into main (1305318) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
- Coverage   65.86%   65.86%   -0.01%     
==========================================
  Files           7        7              
  Lines         791      788       -3     
==========================================
- Hits          521      519       -2     
+ Misses        270      269       -1     
Flag Coverage Δ
integration 53.42% <100.00%> (-0.06%) ⬇️
unit 64.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dropbox.js 100.00% <100.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1305318...f1aa5d0. Read the comment docs.

Copy link
Contributor

@sderickson sderickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rogebrd rogebrd merged commit 71f0a42 into main Apr 4, 2022
@rogebrd rogebrd deleted the fetch_2 branch April 4, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants