Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing extension (for esm) #1101

Open
jimmywarting opened this issue Apr 27, 2023 · 3 comments
Open

missing extension (for esm) #1101

jimmywarting opened this issue Apr 27, 2023 · 3 comments

Comments

@jimmywarting
Copy link

jimmywarting commented Apr 27, 2023

import { DEFAULT_API_DOMAIN, DEFAULT_DOMAIN, TEST_DOMAIN_MAPPINGS } from './constants';

esm require explicit path ./constants.js

@greg-db
Copy link
Contributor

greg-db commented Apr 27, 2023

Thanks for the report! I'll ask the team to fix that up.

@HeratPatel
Copy link

Can I work on this issue?
It looks pretty straight forward and this is my first contribution to this project.

@greg-db
Copy link
Contributor

greg-db commented May 25, 2023

@HeratPatel We welcome pull requests. You can find information on contributing to this SDK here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants