[PL-24913]: Handle the error raised while creating a multipart input #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allofthesepeople
approved these changes
May 11, 2022
tphoney
suggested changes
May 11, 2022
scm/multipart.go
Outdated
| @@ -0,0 +1,26 @@ | |||
| package scm | |||
There was a problem hiding this comment.
So this functionality is only used by stash/content. I would move this helper method in under stash
or
into scm/driver/stash/stash.go
There was a problem hiding this comment.
Since most of the providers uses multipart requests only, the idea is to use this helper function in new APIs. Hence I kept it at a top level
There was a problem hiding this comment.
➜ go-scm git:(no_project) grep -irsn Multipart .
./scm/driver/bitbucket/bitbucket.go:13: "mime/multipart"
./scm/driver/bitbucket/bitbucket.go:74: // add the content to the multipart
./scm/driver/bitbucket/bitbucket.go:77: w := multipart.NewWriter(&b)
./scm/driver/bitbucket/bitbucket.go:95: // write the multipart response to the body
./scm/driver/bitbucket/bitbucket.go:97: // write the content type that contains the length of the multipart
./scm/driver/bitbucket/bitbucket.go:103: writer := multipart.NewWriter(body)
nothing else is using it yet. I would definitely make it only for stash for now. Until another git provider uses it
tphoney
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.