feat: [CI-12041]: add oidc support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutvijmehta-harness
suggested changes
Apr 23, 2024
Sapa96
reviewed
Apr 25, 2024
internal/gcp/tokenutil.go
Outdated
| name := "projects/-/serviceAccounts/" + serviceAccountEmail | ||
| // rb (request body) specifies parameters for generating an access token. | ||
| rb := &iamcredentials.GenerateAccessTokenRequest{ | ||
| Scope: []string{"https://www.googleapis.com/auth/cloud-platform"}, |
Sapa96
reviewed
Apr 25, 2024
| ) | ||
|
|
||
| // decode the token if base64 encoded | ||
| decoded, err := base64.StdEncoding.DecodeString(password) |
There was a problem hiding this comment.
add back base64 decoding for password . it will break existing flow otherwise
raghavharness
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested changes via end-to-end execution with DLC FF enabled and disabled cases.
Tested the execution on Linux Hosted Machine, with 'PL_GCP_OIDC_AUTHENTICATION` FF enabled for OIDC.
Was able to Build a docker image and push it into the GCR repo using the OIDC auth method.
Below are some screen-shots of the executions.
Able to successfully test the changes, please check the jira for more details.
