Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: isTable helper function is not working #2672

Closed
hajek-raven opened this issue Jul 21, 2024 · 1 comment · Fixed by #2673
Closed

[BUG]: isTable helper function is not working #2672

hajek-raven opened this issue Jul 21, 2024 · 1 comment · Fixed by #2673
Labels
bug Something isn't working

Comments

@hajek-raven
Copy link
Contributor

hajek-raven commented Jul 21, 2024 •
edited
Loading

What version of drizzle-orm are you using?

0.32.0

What version of drizzle-kit are you using?

0.23.0

Describe the Bug

isTable function is not working in 0.32.0.

My code uses isTable helper which stopped working in 0.32.0. While quickly reading through drizzle source, it seems that IsDrizzleTable Symbol is unused in the Table class, but isTable function is checking the presence of the Symbol.

Expected behavior

The function isTable should return true when called with a Table.

Environment & setup

pnpm -v
9.4.0
@hajek-raven hajek-raven added the bug Something isn't working label Jul 21, 2024
@hajek-raven hajek-raven mentioned this issue Jul 21, 2024
Merged
@AndriiSherman
Copy link
Member

Should be fixed in drizzle-orm0.33.0
Please check release notes before updating

This was referenced Aug 30, 2024
Merged
Merged
@ShivajiVS ShivajiVS mentioned this issue Aug 30, 2024
Open
This was referenced Sep 10, 2024
Open
Open
Open
Open
This was referenced Sep 22, 2024
Open
Open
@csanchez24 csanchez24 mentioned this issue Sep 23, 2024
Open
@ShivajiVS ShivajiVS mentioned this issue Oct 2, 2024
Open
@NiallJoeMaher NiallJoeMaher mentioned this issue Oct 3, 2024
Closed
@eronisking eronisking mentioned this issue Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix isTable helper function by adding IsDrizzleTable Symbol to Table hajek-raven/drizzle-orm
2 participants
@hajek-raven @AndriiSherman