Skip to content

Commit 5ef2c93

Browse files
authored
Merge pull request #6 from driftphp/fix/fixed-promise-internals
Fixed promise internals
2 parents 1cb6e81 + 4fdd5f8 commit 5ef2c93

File tree

4 files changed

+8
-17
lines changed

4 files changed

+8
-17
lines changed

.circleci/config.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,6 @@ jobs:
88
steps:
99
- checkout
1010

11-
- run:
12-
name: Install PHPUnit
13-
command: |
14-
composer require phpunit/phpunit:7.5.17 --no-update
15-
1611
- run:
1712
name: Run tests / Symfony 4^3
1813
command: |
@@ -33,11 +28,6 @@ jobs:
3328
steps:
3429
- checkout
3530

36-
- run:
37-
name: Install PHPUnit
38-
command: |
39-
composer require phpunit/phpunit:7.5.17 --no-update
40-
4131
- run:
4232
name: Run tests / Symfony 5^0
4333
command: |

composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
"react/stream": "^1.0"
2222
},
2323
"require-dev": {
24-
"clue/block-react": "^1.3"
24+
"clue/block-react": "^1.3",
25+
"phpunit/phpunit" : "7.5.17"
2526
},
2627
"autoload": {
2728
"files": [ "src/functions_include.php" ]

tests/SleepTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55

66
use PHPUnit\Framework\TestCase;
77
use React\EventLoop\Factory;
8-
use React\Promise\FulfilledPromise;
98
use Drift\React;
109
use Clue\React\Block;
10+
use function React\Promise\resolve;
1111

1212
/**
1313
* Class SleepTest
@@ -19,7 +19,7 @@ function testIt()
1919
$loop = Factory::create();
2020
$elements = [];
2121

22-
$promiseXZ = (new FulfilledPromise())
22+
$promiseXZ = resolve()
2323
->then(function() use (&$elements){
2424
$elements[] = 'X';
2525
})
@@ -30,7 +30,7 @@ function testIt()
3030
$elements[] = 'Z';
3131
});
3232

33-
$promiseY = (new FulfilledPromise())
33+
$promiseY = resolve()
3434
->then(function() use ($loop) {
3535
return React\sleep(1, $loop);
3636
})

tests/UsleepTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55

66
use PHPUnit\Framework\TestCase;
77
use React\EventLoop\Factory;
8-
use React\Promise\FulfilledPromise;
98
use Drift\React;
109
use Clue\React\Block;
10+
use function React\Promise\resolve;
1111

1212
/**
1313
* Class UsleepTest
@@ -19,7 +19,7 @@ function testIt()
1919
$loop = Factory::create();
2020
$elements = [];
2121

22-
$promiseXZ = (new FulfilledPromise())
22+
$promiseXZ = resolve()
2323
->then(function() use (&$elements){
2424
$elements[] = 'X';
2525
})
@@ -30,7 +30,7 @@ function testIt()
3030
$elements[] = 'Z';
3131
});
3232

33-
$promiseY = (new FulfilledPromise())
33+
$promiseY = resolve()
3434
->then(function() use ($loop) {
3535
return React\usleep(100, $loop);
3636
})

0 commit comments

Comments
 (0)