-
Notifications
You must be signed in to change notification settings - Fork 74
New Rule to use the whereLike
clause in Laravel 11.x
#267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
reviewed
Oct 29, 2024
peterfox
reviewed
Oct 29, 2024
peterfox
reviewed
Oct 29, 2024
tests/Rector/MethodCall/WhereToWhereLikeRector/Fixture/Postgres/with_postgres_driver.php.inc
Outdated
Show resolved
Hide resolved
peterfox
reviewed
Oct 29, 2024
peterfox
reviewed
Oct 29, 2024
e0d8e0b
to
d5a9408
Compare
peterfox
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @GeniJaho !
@GeniJaho Just a note for the ones who apply this rule, tests broke when applied this rule for the first where: before rector (passing): $query
->where('name', 'ilike', DB::raw("UNACCENT('%{$filter}%')"))
->orWhereRelation('approaches.influencer', DB::raw('UNACCENT(searchable)'), 'ilike', DB::raw("UNACCENT('%{$filter}%')")); after this rector rule ("ERROR: Object of class Illuminate\Database\Query\Expression could not be converted to string") $query
->whereLike('name', DB::raw("UNACCENT('%{$filter}%')"))
->orWhereRelation('approaches.influencer', DB::raw('UNACCENT(searchable)'), 'ilike', DB::raw("UNACCENT('%{$filter}%')")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new rule
WhereToWhereLike
(open for a better name) that will migrate all the->where('name', 'like', '%Rector%')
clauses into the newwhereLike()
introduced in Laravel 11.x.