patched vuln ZDI-CAN-26589 Command Injection #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved logging from saveZipFile to encryptZipWithNativeMethod for better separation of concerns and consistency with encryptZipWithShellCommand. Benefits: - Each encryption method now handles its own success logging - Simplified saveZipFile logic from 9 lines to 4 lines - Improved symmetry: both encryption methods follow same pattern - Better single responsibility principle adherence Changes: - Added logging to encryptZipWithNativeMethod at line 702 - Simplified if/else logic to use negation (!$this->encryptZipWithNativeMethod) - Removed logging from saveZipFile method 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX FOR:
The endpoint
/api/v2/system/packageis vulnerable to command injection attacks. Authentication is requred to exploit this vulnerability.