Skip to content

Commit 7adb071

Browse files
authored
fix: test_replica_snapshot_with_big_values_while_seeding (#4902)
* throttle the test to require less memory * increase reg test timeout on the ci from 50 to 60 mins Signed-off-by: kostas <kostas@dragonflydb.io>
1 parent c129834 commit 7adb071

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

.github/actions/regression-tests/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ runs:
5454
if [[ "${{inputs.epoll}}" == 'epoll' ]]; then
5555
export FILTER="${{inputs.filter}} and not exclude_epoll"
5656
# Run only replication tests with epoll
57-
timeout 50m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --df force_epoll=true --log-cli-level=INFO || code=$?
57+
timeout 60m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --df force_epoll=true --log-cli-level=INFO || code=$?
5858
else
5959
export FILTER="${{inputs.filter}}"
6060
# Run only replication tests with epoll
61-
timeout 50m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --log-cli-level=INFO || code=$?
61+
timeout 60m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --log-cli-level=INFO || code=$?
6262
fi
6363
6464
# timeout returns 124 if we exceeded the timeout duration

tests/dragonfly/replication_test.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2977,7 +2977,7 @@ async def test_bug_in_json_memory_tracking(df_factory: DflyInstanceFactory):
29772977
rand = random.randint(1, 4)
29782978
await c_master.execute_command(f"EXPIRE tmp:{i} {rand} NX")
29792979

2980-
seeder = SeederV2(key_target=100_000)
2980+
seeder = SeederV2(key_target=50_000)
29812981
fill_task = asyncio.create_task(seeder.run(master.client()))
29822982

29832983
for replica in c_replicas:
@@ -2989,7 +2989,6 @@ async def test_bug_in_json_memory_tracking(df_factory: DflyInstanceFactory):
29892989
await fill_task
29902990

29912991

2992-
@pytest.mark.skip("Skipped temporarily while being investigated")
29932992
async def test_replica_snapshot_with_big_values_while_seeding(df_factory: DflyInstanceFactory):
29942993
proactors = 4
29952994
master = df_factory.create(proactor_threads=proactors, dbfilename="")
@@ -2999,7 +2998,7 @@ async def test_replica_snapshot_with_big_values_while_seeding(df_factory: DflyIn
29992998
c_replica = replica.client()
30002999

30013000
# 50% big values
3002-
seeder_config = dict(key_target=20_000, huge_value_target=10000)
3001+
seeder_config = dict(key_target=8_000, huge_value_target=4_000)
30033002
# Fill instance with test data
30043003
seeder = SeederV2(**seeder_config)
30053004
await seeder.run(c_master, target_deviation=0.01)

0 commit comments

Comments
 (0)