Migrate binder transport end-to-end tests to use the existing testing service (grpc#27179)

* Use TestServiceImpl in binder end-to-end tests

* Fix TSAN warnings

Author: TaWeiTu

CMakeLists.txt

@@ -52,7 +52,8 @@ struct grpc_binder_stream {
         refcount(refcount),
         arena(arena),
         tx_code(tx_code),
-        is_client(is_client) {
+        is_client(is_client),
+        is_closed(false) {
     // TODO(waynetu): Should this be protected?
     t->registered_stream[tx_code] = this;
 
@@ -79,8 +80,8 @@ struct grpc_binder_stream {
   grpc_core::Arena* arena;
   grpc_core::ManualConstructor<grpc_core::SliceBufferByteStream> sbs;
   int tx_code;
-  bool is_client;
-  bool is_closed = false;
+  const bool is_client;
+  bool is_closed;
 
   grpc_closure* destroy_stream_then_closure = nullptr;
   grpc_closure destroy_stream;

build_autogenerated.yaml

@@ -482,10 +482,6 @@ static void perform_stream_op_locked(void* stream_op,
         tx_code, [tx_code, gbs,
                   gbt](absl::StatusOr<grpc_binder::Metadata> initial_metadata) {
           grpc_core::ExecCtx exec_ctx;
-          if (gbs->is_closed) {
-            GRPC_BINDER_STREAM_UNREF(gbs, "recv_initial_metadata");
-            return;
-          }
           gbs->recv_initial_metadata_args.tx_code = tx_code;
           gbs->recv_initial_metadata_args.initial_metadata =
               std::move(initial_metadata);
@@ -506,10 +502,6 @@ static void perform_stream_op_locked(void* stream_op,
     gbt->transport_stream_receiver->RegisterRecvMessage(
         tx_code, [tx_code, gbs, gbt](absl::StatusOr<std::string> message) {
           grpc_core::ExecCtx exec_ctx;
-          if (gbs->is_closed) {
-            GRPC_BINDER_STREAM_UNREF(gbs, "recv_message");
-            return;
-          }
           gbs->recv_message_args.tx_code = tx_code;
           gbs->recv_message_args.message = std::move(message);
           gbt->combiner->Run(
@@ -530,10 +522,6 @@ static void perform_stream_op_locked(void* stream_op,
                      absl::StatusOr<grpc_binder::Metadata> trailing_metadata,
                      int status) {
           grpc_core::ExecCtx exec_ctx;
-          if (gbs->is_closed) {
-            GRPC_BINDER_STREAM_UNREF(gbs, "recv_trailing_metadata");
-            return;
-          }
           gbs->recv_trailing_metadata_args.tx_code = tx_code;
           gbs->recv_trailing_metadata_args.trailing_metadata =
               std::move(trailing_metadata);

src/core/ext/transport/binder/transport/binder_stream.h

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-load("//bazel:grpc_build_system.bzl", "grpc_cc_library", "grpc_cc_test", "grpc_package", "grpc_proto_library")
+load("//bazel:grpc_build_system.bzl", "grpc_cc_library", "grpc_cc_test", "grpc_package")
 
 licenses(["notice"])
 
@@ -72,26 +72,6 @@ grpc_cc_library(
     ],
 )
 
-grpc_proto_library(
-    name = "echo_grpc_proto",
-    srcs = ["echo.proto"],
-)
-
-grpc_cc_library(
-    name = "echo_service",
-    testonly = 1,
-    srcs = ["echo_service.cc"],
-    hdrs = ["echo_service.h"],
-    external_deps = [
-        "absl/strings",
-        "absl/strings:str_format",
-        "absl/time",
-    ],
-    deps = [
-        ":echo_grpc_proto",
-    ],
-)
-
 grpc_cc_test(
     name = "end2end_binder_transport_test",
     srcs = ["end2end_binder_transport_test.cc"],
@@ -102,12 +82,12 @@ grpc_cc_test(
     ],
     language = "C++",
     deps = [
-        ":echo_service",
         ":end2end_binder_channel",
         ":fake_binder",
         "//src/core/ext/transport/binder/transport:binder_transport",
         "//src/core/ext/transport/binder/wire_format:wire_reader",
         "//test/core/util:grpc_test_util",
+        "//test/cpp/end2end:test_service_impl",
     ],
 )
 
@@ -121,7 +101,6 @@ grpc_cc_test(
         "//:grpc++",
         "//src/core/ext/transport/binder/client:grpc_transport_binder_client_impl",
         "//src/core/ext/transport/binder/server:grpc_transport_binder_server",
-        "//test/core/transport/binder/end2end:echo_service",
         "//test/core/transport/binder/end2end:fake_binder",
         "//test/core/util:grpc_test_util",
         "//test/cpp/end2end:test_service_impl",