Skip to content

Duplicate imports do not have a consistent ordering #620

Open
@jakebailey

Description

@jakebailey

Describe the bug

I'm looking into removing the ESLint plugin we use on TS to sort/group imports, as using dprint to do this would be a lot faster and less noisy. But, for "reasons" we have files that need to import from the same module specifier more than once. While messing with imports to try and make sure that sorting was working, I noticed that reordering those duplicates didn't net a single output.

I'm not 100% sure how to sort between these, but eslint-plugin-simple-import-order seems to do it. At least in the examples below, I think the ordering is at least sort of clear; stick the namespace import before the declaration with named imports.

dprint-plugin-typescript version: 0.90.0

Input Code

import * as ts from "../../_namespaces/ts";
import { ScriptTarget } from "../../_namespaces/ts";
import * as evaluator from "../../_namespaces/evaluator";

import { ScriptTarget } from "../../_namespaces/ts";
import * as ts from "../../_namespaces/ts";
import * as evaluator from "../../_namespaces/evaluator";

Expected Output

import * as evaluator from "../../_namespaces/evaluator";
import * as ts from "../../_namespaces/ts";
import { ScriptTarget } from "../../_namespaces/ts";


import * as evaluator from "../../_namespaces/evaluator";
import * as ts from "../../_namespaces/ts";
import { ScriptTarget } from "../../_namespaces/ts";

Actual Output

import * as evaluator from "../../_namespaces/evaluator";
import * as ts from "../../_namespaces/ts";
import { ScriptTarget } from "../../_namespaces/ts";


import * as evaluator from "../../_namespaces/evaluator";
import { ScriptTarget } from "../../_namespaces/ts";
import * as ts from "../../_namespaces/ts";

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions