Fix bug in dump() caused by incorrectly passing args to dumps()#35
Merged
dpranke merged 1 commit intodpranke:masterfrom Mar 17, 2020
pastelmind:bugfix/dump-args
Merged
Fix bug in dump() caused by incorrectly passing args to dumps()#35dpranke merged 1 commit intodpranke:masterfrom pastelmind:bugfix/dump-args
dpranke merged 1 commit intodpranke:masterfrom
pastelmind:bugfix/dump-args
Conversation
Fix a bug (caused by a missing cls) that caused dump() to pass arguments to dumps() incorrectly.
Owner
|
Oops. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dump()was broken because it wasn't passing theclsparameter todumps(). I fixed it and also made it pass all arguments using keywords, which should help prevent similar bugs ifdumps()learns new keyword arguments in the future.