Skip to content

Commit 2b071d7

Browse files
committed
Exclude testapp submodules from built packages
The controls in `MANIFEST.in` are unfortunately neither necessary nor sufficient to control the inclusion of files from the 'testapp' directory in wheels built from the original source. Those are instead controlled by the packages listed in `setup.py`, as found by `find_packages`. It is unclear to me why `find_packages` requires explicitly excluding both 'testapp' and 'testapp*' (either spelling on its own isn't sufficient to exclude both files in the 'testapp' folder as well as those within subfolders), however from testing this combination has the desired effect. In theory this commit could remove the exclusion from `MANIFEST.in`, allowing the test files to be included in the source distribution now that they are fully excluded from the installed files, however it is the maintainer's preference that the files also be completely excluded from the source distribution too, so that is left unchanged. Tested by manually installing locally built source and wheel distribution packages and verifying what files were included within 'site-pacakges'. Fixes jrief#359
1 parent 19cfa7e commit 2b071d7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def readfile(filename):
4747
install_requires=[
4848
'Django>=4.0',
4949
],
50-
packages=find_packages(exclude=['client', 'testapp', 'docs']),
50+
packages=find_packages(exclude=['client', 'testapp', 'testapp*', 'docs']),
5151
include_package_data=True,
5252
zip_safe=False,
5353
)

0 commit comments

Comments
 (0)