Dont wakeup during maybe_refresh_metadata -- it is only called by poll() #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you want to document that with an inline code comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplification of #1765 , intended to address / fix #1760 . The underlying issue here is that if the wakeup socket is full, and so will block on writes, we don't want anything within the poll() method to attempt to write to this socket. This PR updates _maybe_refresh_metadata() to not use wakeups. Because this method is only ever called within poll(), I have made the default wakeup=False. In the future, if the method were invoked from outside / another thread, we would want to pass wakeup=True.
This change is