Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close KafkaConsumer instances during tests #1410

Merged
merged 3 commits into from
Mar 8, 2018
Merged

Conversation

dpkp
Copy link
Owner

@dpkp dpkp commented Mar 7, 2018

Eventually we should get a context manager interface, but for now we should just take care to close the consumer instances to avoid lingering heartbeat threads during long test runs.

@dpkp dpkp merged commit 4c383da into master Mar 8, 2018
@dpkp dpkp deleted the close_consumer_tests branch March 8, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant