Skip to content

Commit 86cf74e

Browse files
authored
SimpleWebSocketServer: honor selectInterval=0
Currently for selectInterval=0 case, SimpleWebSocketServer removes the argument completely from the `select()` call, which means "no timeout". For wrapping SimpleWebSocketServer in an async library, it's useful to support a timeout of 0 so that select returns immediately. The cited behavior has been removed, so that selectInterval=0 and selectInterval=None are passed as-is to `select()`. The default value of .1 seconds is unchanged.
1 parent 34e6def commit 86cf74e

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

SimpleWebSocketServer/SimpleWebSocketServer.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -614,10 +614,7 @@ def serveonce(self):
614614
if client.sendq:
615615
writers.append(fileno)
616616

617-
if self.selectInterval:
618-
rList, wList, xList = select(self.listeners, writers, self.listeners, self.selectInterval)
619-
else:
620-
rList, wList, xList = select(self.listeners, writers, self.listeners)
617+
rList, wList, xList = select(self.listeners, writers, self.listeners, self.selectInterval)
621618

622619
for ready in wList:
623620
client = self.connections[ready]

0 commit comments

Comments
 (0)