Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev mode adds more hooks for testing purposes #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DeanLa
Copy link
Member

@DeanLa DeanLa commented Oct 22, 2019

No description provided.

@galbraun
Copy link
Collaborator

IMHO it will be more robust to add a level parameter to the hooks and not split it like this - in the case, you'll want to add a different type of group you'll need to add another file in this way. WDYT?

@DeanLa
Copy link
Member Author

DeanLa commented Oct 22, 2019

Agree. Currently a hook is 2-tuple with (hook_functiob, hook_type).
I believe it will be best to create a Hook class with those properties. it will also make it easier to call for different methods and custom display even.

@DeanLa DeanLa added _Framework enhancement New feature or request labels Oct 23, 2019
@galbraun galbraun added the blocked Blocked until a different PR or issue will be solved label Oct 23, 2019
@galbraun
Copy link
Collaborator

Waiting for #24 to be merged so we can refer level of the ledger from self

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked until a different PR or issue will be solved enhancement New feature or request _Framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants