Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Step still succeeds if key doesn't exist and the update fails #45

Open
Dermah opened this issue Dec 6, 2021 · 0 comments
Open

Step still succeeds if key doesn't exist and the update fails #45

Dermah opened this issue Dec 6, 2021 · 0 comments

Comments

@Dermah
Copy link

Dermah commented Dec 6, 2021

My page update failed with the following log:

Run dovetail/notion-update-page-property@v0.1.0
  with:
    notion_api_key: ***
    page_id: <REDACTED>
    key: Pull request
    value: { "url": "<REDACTED>" }
(node:1474) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
@notionhq/client warn: request fail {
  code: 'validation_error',
  message: 'Pull request is not a property that exists.'
}
(node:1474) UnhandledPromiseRejectionWarning: APIResponseError: Pull request is not a property that exists.
    at Object.buildRequestError (/home/runner/work/_actions/dovetail/notion-update-page-property/v0.1.0/node_modules/@notionhq/client/build/src/errors.js:162:1)
    at Client.request (/home/runner/work/_actions/dovetail/notion-update-page-property/v0.1.0/node_modules/@notionhq/client/build/src/Client.js:278:1)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
(node:1474) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1474) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

The page update failed, but the GitHub workflow was still marked as succeeded.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant