Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Orderable interface for SQL Functions #251

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

GlebBeloded
Copy link

@GlebBeloded GlebBeloded commented Jan 28, 2021

A detailed description of the issue can be found here: #250

@GlebBeloded GlebBeloded changed the title #250 implement orderBy for SqlFunction implement Orderable for interface for SQL Functions Jan 28, 2021
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #251 (771c22c) into master (865b53c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   96.67%   96.67%           
=======================================
  Files          60       60           
  Lines        3278     3282    +4     
=======================================
+ Hits         3169     3173    +4     
  Misses         94       94           
  Partials       15       15           
Impacted Files Coverage Δ
exp/exp.go 67.14% <ø> (ø)
exp/func.go 100.00% <100.00%> (ø)
exp/window_func.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865b53c...771c22c. Read the comment docs.

@GlebBeloded GlebBeloded changed the title implement Orderable for interface for SQL Functions implement Orderable interface for SQL Functions Jan 28, 2021
@GlebBeloded GlebBeloded marked this pull request as ready for review January 28, 2021 16:05
@doug-martin doug-martin merged commit ee815b3 into doug-martin:master Mar 5, 2021
@doug-martin doug-martin mentioned this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants