use valid 'IS' operator for sqlserver dialect, fixes #239 #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 96.67% 96.68% +0.01%
==========================================
Files 60 60
Lines 3278 3292 +14
==========================================
+ Hits 3169 3183 +14
Misses 94 94
Partials 15 15
Continue to review full report at Codecov.
|
|
@doug-martin any chance to merge this? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my proposal for fixing #239, new side effect is that explicit error will be returned when trying to construct query with IS / IS NOT operator other than for NULL value as RHS
Also, seems like support of boolean data type is a common "problem", AFAIK Oracle also does not have support for boolean, so explicit specification of it on dialect level looks good.
second commit is about handling panics in WithTx. It is not very uncommon situation when panic occurs inside for example REST handler for some reason. In this case current implementation will end up with "stuck" transaction which could prevent another transactions from normal operation.