Skip to content

Commit f4750b7

Browse files
committed
Collection: fix updateMany success return type UpdateResult<I> to allow custom defined _id types
1 parent fd9fd6c commit f4750b7

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

.changeset/forty-lemons-fix.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"effect-mongodb": patch
3+
---
4+
5+
Fix `Collection.updateMany` success return type `UpdateResult<I>` to allow custom defined `_id` types

packages/effect-mongodb/dtslint/Collection.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@ F.pipe(collection, Collection.deleteMany({ birthday: "2024-11-28" }))
8181
// updateMany
8282
// -------------------------------------------------------------------------------------
8383

84-
// $ExpectType Effect<UpdateResult<Document>, MongoError, never>
84+
// $ExpectType Effect<UpdateResult<{ readonly birthday: string; }>, MongoError, never>
8585
Collection.updateMany(collection, { birthday: "2024-11-28" }, { $set: { birthday: "2024-11-29" } })
8686

87-
// $ExpectType Effect<UpdateResult<Document>, MongoError, never>
87+
// $ExpectType Effect<UpdateResult<{ readonly birthday: string; }>, MongoError, never>
8888
F.pipe(collection, Collection.updateMany({ birthday: "2024-11-28" }, { $set: { birthday: "2024-11-29" } }))
8989

9090
// -------------------------------------------------------------------------------------

packages/effect-mongodb/src/Collection.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -187,23 +187,23 @@ export const updateMany: {
187187
filter: Filter<I>,
188188
update: UpdateFilter<I> | ReadonlyArray<Document>,
189189
options?: UpdateOptions
190-
): <A extends Document, R>(
191-
collection: Collection<A, I, R>
192-
) => Effect.Effect<UpdateResult, MongoError.MongoError, R>
190+
): <A extends Document, I2 extends I, R>(
191+
collection: Collection<A, I2, R>
192+
) => Effect.Effect<UpdateResult<I2>, MongoError.MongoError, R>
193193
<A extends Document, I extends Document, R>(
194194
collection: Collection<A, I, R>,
195195
filter: Filter<I>,
196196
update: UpdateFilter<I> | ReadonlyArray<Document>,
197197
options?: UpdateOptions
198-
): Effect.Effect<UpdateResult, MongoError.MongoError, R>
198+
): Effect.Effect<UpdateResult<I>, MongoError.MongoError, R>
199199
} = F.dual(
200200
(args) => isCollection(args[0]),
201201
<A extends Document, I extends Document, R>(
202202
collection: Collection<A, I, R>,
203203
filter: Filter<I>,
204204
update: UpdateFilter<I> | ReadonlyArray<Document>,
205205
options?: UpdateOptions
206-
): Effect.Effect<UpdateResult, MongoError.MongoError, R> =>
206+
): Effect.Effect<UpdateResult<I>, MongoError.MongoError, R> =>
207207
Effect.promise(() =>
208208
collection.collection.updateMany(
209209
filter,

0 commit comments

Comments
 (0)