Skip to content

extracted ProjectSelectionBox Logic into its own class #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

extracted ProjectSelectionBox Logic into its own class #72

wants to merge 1 commit into from

Conversation

JSchraff
Copy link
Contributor

extracted ProjectSelectionBox Logic into its own class to enable reuseability

@JSchraff
Copy link
Contributor Author

could be beneficial to extract the searching logic into its own class independent of Project, but cannot find a direct usecase, that justifys the overhead of generalisation.

@JSchraff JSchraff requested a review from Death111 July 20, 2020 07:52
@Death111
Copy link
Collaborator

this would be interesting for the #178 feature which uses a lot of comboboxes. I was not able to get it work :p
It had issues when using in a ListView (which reuses comboxes when scrolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Death111 Death111 Awaiting requested review from Death111

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSchraff @Death111