fix(AutoComplete): missing value when click delete item #5814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a new delete trigger to the AutoComplete component, allowing the component to handle delete key events. The changes include adding a new attribute to the input element, a new method to handle delete key events, and updating the JavaScript to invoke the new method when the delete key is pressed. The pull request also includes enhancements to the unit tests for the AutoComplete component and removes the unused ClassString property. Sequence diagram for handling delete key event in AutoComplete componentsequenceDiagram
participant User
participant AutoComplete.razor
participant AutoComplete.razor.js
User->>AutoComplete.razor: Types in input field and presses Delete key
AutoComplete.razor->>AutoComplete.razor.js: Captures Delete key event
AutoComplete.razor.js->>AutoComplete.razor.js: Checks data-bb-trigger-delete attribute
alt data-bb-trigger-delete is true
AutoComplete.razor.js->>AutoComplete.razor: Invokes TriggerDeleteCallback(input.value)
AutoComplete.razor->>AutoComplete.razor: Updates CurrentValue
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider debouncing the
TriggerDeleteCallbackmethod to avoid excessive calls. - The
_renderflag seems unnecessary; consider removing it for simplification.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5814 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30123 30125 +2
Branches 4251 4251
=========================================
+ Hits 30123 30125 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5813
Summary By Copilot
This pull request includes several changes to the
AutoCompletecomponent in theBootstrapBlazorlibrary. The changes focus on improving the functionality and testing of theAutoCompletecomponent by adding a new delete trigger and refactoring some existing code.Improvements to
AutoCompletecomponent functionality:src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor: Added a new attributedata-bb-trigger-delete="true"to the input element to handle delete key events.src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.cs: Added a new methodTriggerDeleteCallbackto handle delete key events and update theCurrentValue. Removed the unusedClassStringproperty. [1] [2]src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js: Updated the JavaScript to invoke the newTriggerDeleteCallbackmethod when the delete key is pressed.Enhancements to unit tests:
test/UnitTest/Components/AutoCompleteTest.cs: Updated theItems_Oktest to check for the newdata-bb-trigger-deleteattribute and added a test case for theTriggerDeleteCallbackmethod. [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve AutoComplete component functionality by adding delete key handling and refactoring related code
Bug Fixes:
Enhancements:
Tests: