-
-
Notifications
You must be signed in to change notification settings - Fork 331
refactor(Table): throw exception when set IsTree to true in virtualize mode #5723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a check to prevent the use of virtual scrolling in tree mode in the Updated class diagram for the Table componentclassDiagram
class Table {
ScrollMode ScrollMode
bool IsTree
OnParametersSet()
}
note for Table "Throws InvalidOperationException if ScrollMode is Virtual and IsTree is true"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the exception throwing logic into a separate method for better readability.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5723 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29829 29832 +3
Branches 4229 4230 +1
=========================================
+ Hits 29829 29832 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5722
fixes #5685
Summary By Copilot
This pull request introduces a check to prevent the use of virtual scrolling in tree mode in the
Table
component and updates the corresponding unit tests to validate this behavior.Changes to
Table
component:OnParametersSet
method to throw anInvalidOperationException
ifScrollMode
is set toVirtual
andIsTree
istrue
. (src/BootstrapBlazor/Components/Table/Table.razor.cs
)Changes to unit tests:
ScrollMode_Ok
test to prevent unnecessary logs during test execution. (test/UnitTest/Components/TableTest.cs
)InvalidOperationException
is thrown whenIsTree
is set totrue
whileScrollMode
isVirtual
. (test/UnitTest/Components/TableTest.cs
)Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Prevent using virtual scrolling with tree mode in Table component by adding a validation check that throws an exception when incompatible settings are configured
Bug Fixes:
Tests: