feat(Utility): add custom changed.bb.theme event#5709
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request refactors the Sequence diagram for theme change eventsequenceDiagram
participant User
participant utility.js
participant Pre.razor.js
User->>utility.js: setTheme(theme)
activate utility.js
utility.js->>utility.js: saveTheme(theme)
utility.js->>utility.js: localStorage.setItem("theme", theme)
utility.js->>document: EventHandler.trigger(document, 'changed.bb.theme', { theme: theme })
deactivate utility.js
document-->>Pre.razor.js: changed.bb.theme event
activate Pre.razor.js
Pre.razor.js->>Pre.razor.js: updateTheme(e)
Pre.razor.js->>Pre.razor.js: switchTheme(theme)
deactivate Pre.razor.js
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider debouncing the
changed.bb.themeevent to avoid excessive updates.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5709 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29824 29824
Branches 4226 4226
=========================================
Hits 29824 29824 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5708
Summary By Copilot
This pull request includes changes to the
src/BootstrapBlazor.Server/Components/Components/Pre.razor.csandsrc/BootstrapBlazor.Server/Components/Components/Pre.razor.jsfiles to remove the theme handling logic from the C# code and move it to the JavaScript code. Additionally, minor updates were made to other JavaScript files to improve code consistency.Theme handling changes:
src/BootstrapBlazor.Server/Components/Components/Pre.razor.cs: Removed theThemeProviderServiceproperty and theOnThemeChangedmethod. [1] [2] [3]src/BootstrapBlazor.Server/Components/Components/Pre.razor.js: Added theregisterBootstrapBlazorModulefunction call to handle theme changes and updated thedisposemethod to unregister the theme change event. [1] [2] [3]Code consistency improvements:
src/BootstrapBlazor/wwwroot/modules/base-popover.js: Replaced the nullish coalescing operator with the logical OR operator for better compatibility.src/BootstrapBlazor/wwwroot/modules/utility.js: ImportedEventHandlerand added an event trigger for theme changes in thesetThemefunction. [1] [2]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Refactors theme handling for the Pre component by moving the logic from C# to JavaScript, and triggers a custom 'changed.bb.theme' event when the theme is changed. This allows JavaScript modules to react to theme changes.
New Features:
Enhancements: