-
-
Notifications
You must be signed in to change notification settings - Fork 331
feat(LayoutSidebar): add LayoutSplitebar component #5438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new Class diagram for LayoutSidebar componentclassDiagram
class LayoutSidebar {
+string? ContainerSelector
+int? Min
+int? Max
}
LayoutSidebar : BootstrapModuleComponentBase
note for LayoutSidebar "Component to allow resizing of the sidebar"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a consistent naming scheme, such as
LayoutSplitter
, to better reflect the component's purpose. - The javascript interop could be moved into the component to make it more self-contained.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5438 +/- ##
===========================================
- Coverage 100.00% 99.97% -0.03%
===========================================
Files 645 646 +1
Lines 29355 29349 -6
Branches 4131 4129 -2
===========================================
- Hits 29355 29342 -13
- Misses 0 7 +7 ☔ View full report in Codecov by Sentry. |
add LayoutSidebar component
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5437
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
This pull request introduces a new
LayoutSidebar
component that allows users to resize the sidebar. TheLayout
component was refactored to use aRenderSide
fragment, improving code organization and reusability. AShowSplitBar
parameter was added to theLayout
component to control the visibility of theLayoutSidebar
component.New Features:
LayoutSidebar
component that allows users to resize the sidebar.Enhancements:
Layout
component to use aRenderSide
fragment, improving code organization and reusability.ShowSplitBar
parameter to theLayout
component to control the visibility of theLayoutSidebar
component.Build:
LayoutSidebar
component.Tests: