-
-
Notifications
You must be signed in to change notification settings - Fork 331
doc(Select): update bind enum data type sample code #5044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR updates the sample code for binding enum data types in the Select component. It corrects the boolean values in the Class diagram showing updated NullableBoolItems structureclassDiagram
class SelectedItem {
+string Text
+string Value
}
class NullableBoolItems {
+SelectedItem[] items
}
NullableBoolItems --> SelectedItem
note for NullableBoolItems "Updated Value strings from 'true'/'false' to 'True'/'False'"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5044 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 631 631
Lines 27964 27964
Branches 4008 4008
=========================================
Hits 27964 27964 ☔ View full report in Codecov by Sentry. |
update bind enum data type sample code
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5043
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the sample code for binding enum data types in the Select component.
Enhancements:
<section ignore>
tags in theSliders.razor
,Selects.razor
example code files to exclude them from unit tests.Documentation:
Tests:
NullableBoolItems
array within theSelects.razor.cs
file to align with the expected "True" and "False" string representations.