refactor(ILookup): add GetItemsAsync extension method #4979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: HUGO.CM <6092940+cm0201@users.noreply.github.com>
# Conflicts: # src/BootstrapBlazor/BootstrapBlazor.csproj Co-Authored-By: HUGO.CM <6092940+cm0201@users.noreply.github.com>
Reviewer's Guide by SourceryThis pull request introduces the Sequence diagram for GetItemsAsync extension methodsequenceDiagram
participant Component as Component implementing ILookup
participant Extension as ILooupExtensions
participant Service as ILookupService
Component->>Extension: GetItemsAsync(service, key, data)
alt Lookup property exists
Extension-->>Component: Return Lookup property
else Lookup is null
Extension->>Service: GetItemsByKey(key, data)
alt Sync lookup exists
Service-->>Extension: Return sync lookup
else Sync lookup is null
Extension->>Service: GetItemsByKeyAsync(key, data)
Service-->>Extension: Return async lookup
end
Extension-->>Component: Return lookup items
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4979 +/- ##
===========================================
+ Coverage 99.96% 100.00% +0.03%
===========================================
Files 579 630 +51
Lines 24790 28070 +3280
Branches 3584 4025 +441
===========================================
+ Hits 24781 28070 +3289
+ Misses 4 0 -4
+ Partials 5 0 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add GetItemsAsync extension method
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #4978
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Introduce the GetItemsAsync extension method for ILookup.
New Features:
Tests: