[Managed DWrite] Migrate part of DWriteTypeConverter to managed #9902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
harshit7962
added
Status:Completed
Included in test pass
and removed
Included in test pass
Status:InProgress
Status:Proposed
labels
JeremyKuhne
previously approved these changes
Oct 29, 2024
| // We do not support Natural Metrics mode in WPF | ||
| // However, the build system complained about not having an explicit case | ||
| // for DWRITE_TEXT_MEASURING_METHOD_USE_DISPLAY_NATURAL_METRICS | ||
| case DWRITE_MEASURING_MODE.DWRITE_MEASURING_MODE_GDI_NATURAL: |
There was a problem hiding this comment.
nit: slightly better to fall through here and only have one throw.
There was a problem hiding this comment.
I wanted to keep the case for the comment but I didn't think about just merging case DWRITE_MEASURING_MODE.DWRITE_MEASURING_MODE_GDI_NATURAL with default. I pushed a commit the just merges the 2 and removes the duplicate throw.
|
@JeremyKuhne Do you mind reviewing #6260 as well ? It's in the same vein. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5305
Description
Migrate part of DWriteTypeConverter to managed. I also removed some dead code from my previous Managed DWrite PR. I changed the name of
DWriteTypeConverterin PresentationCore toDWriteTypeConverterExbecause it conflicted with the one in DirectWriteForwarder.Customer Impact
It might be faster and should allow better support of trimming and the support of NativeAOT once everything is migrated to C#.
Regression
No.
Testing
Local testing.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow