Skip to content

Suppress SYSLIB5005 for System.Formats.Nrbf as experimental #9791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeffhandley
Copy link
Member

@jeffhandley jeffhandley commented Sep 17, 2024

With dotnet/runtime#107905, we are marking System.Formats.Nrbf as [Experimental], using diagnostic ID SYSLIB5005. This suppresses the diagnostics produced by that annotation.

We plan to backport this change to release/9.0 and release/9.0-rc2.

Microsoft Reviewers: Open in CodeFlow

@singhashish-wpf singhashish-wpf merged commit 7551266 into dotnet:main Sep 17, 2024
8 checks passed
@singhashish-wpf
Copy link
Member

/backport to release/9.0

Copy link

Started backporting to release/9.0: https://github.com/dotnet/wpf/actions/runs/10901192879

Copy link

Started backporting to release/9.0-rc2: https://github.com/dotnet/wpf/actions/runs/10901198288

@dotnet dotnet deleted a comment from github-actions bot Sep 17, 2024
@jeffhandley jeffhandley deleted the jeffhandley/nrbf-experimental branch September 17, 2024 15:01
@jeffhandley
Copy link
Member Author

/backport to release/9.0-rc2

Copy link

Started backporting to release/9.0-rc2: https://github.com/dotnet/wpf/actions/runs/10908569408

Copy link

@jeffhandley an error occurred while backporting to release/9.0-rc2, please check the run log for details!

Error: The specified backport target branch release/9.0-rc2 wasn't found in the repo.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants