Remove unnecessary array allocations in SelectionProcessor/SubTreeProcessor #9597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to prevent casts and enumerator
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary static array allocations of
XmlQualifiedNameand their subsequent clones on getters, replacing it with simpleReadOnlySpan<XmlQualifiedName>returning a reference to a static field.Also replaces
GetSelectedNodesto return aReadOnlySpan<DependencyObject>which can then be used inBuildPathForElementsfor faster enumeration and strongly-typed access.Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build, CI.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow