-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Refactor WeakReferenceList/CopyOnWriteList as type-safe generic collections #10889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
h3xds1nz
wants to merge
24
commits into
dotnet:main
Choose a base branch
from
h3xds1nz:copy-on-write
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10889 +/- ##
===================================================
- Coverage 13.48885% 2.98844% -10.50041%
===================================================
Files 3317 3319 +2
Lines 664749 664828 +79
Branches 74643 74664 +21
===================================================
- Hits 89667 19868 -69799
- Misses 572488 644779 +72291
+ Partials 2594 181 -2413
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lindexi
reviewed
May 30, 2025
lindexi
reviewed
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors both
CopyOnWriteList
andWeakReferenceList
as generic type-safe collections.Both lists now support initialization with capacity argument, previously integers passed in (e.g. in
PropagateParentOwners
) would end up being boxed and the instance of the box being used as a lock. This clearly feels like a mistake.In
ResourceDictionaryDiagnostics
I've removed few static fields caching empty (readonly) arrays I didn' see in #10267.Regarding the removed null-checks:
as
casting pattern.null
in the first place.Since
ContainsOwner
is only called from within the three classes, we can remove the type checks and speed it up.Customer Impact
Improved performance a tiny bit, strongly-typed code and newer practices.
Regression
No.
Testing
Local build, unit tests, testing with sample apps including themes and templates.
Risk
Low to medium, I believe the changes are straightforward and understandable but happy to answer any questions (rather sooner than later).
Microsoft Reviewers: Open in CodeFlow