Skip to content

Stop boxing booleans in DataBindEngine, use BooleanBoxes instead #10628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

using System.Windows;
using System.Windows.Data;
using MS.Internal.KnownBoxes;

namespace MS.Internal.Data
{
Expand Down Expand Up @@ -580,12 +581,12 @@ private void ProcessCrossThreadRequests()
private void RequestRun()
{
// Run tasks before layout, to front load as much layout work as possible
Dispatcher.BeginInvoke(DispatcherPriority.DataBind, new DispatcherOperationCallback(Run), false);
Dispatcher.BeginInvoke(DispatcherPriority.DataBind, new DispatcherOperationCallback(Run), BooleanBoxes.FalseBox);

// Run tasks (especially re-tried AttachToContext tasks) again after
// layout as the last chance. Any failures in AttachToContext will
// be treated as an error.
Dispatcher.BeginInvoke(DispatcherPriority.Loaded, new DispatcherOperationCallback(Run), true);
Dispatcher.BeginInvoke(DispatcherPriority.Loaded, new DispatcherOperationCallback(Run), BooleanBoxes.TrueBox);
}

// run a cleanup pass
Expand Down