Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor StronglyTypedResourceBuilder to replace Hashtable with Dictionary #8677

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Refactor StronglyTypedResourceBuilder to replace Hashtable with Dictionary #8677

merged 4 commits into from
Feb 23, 2023

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Feb 23, 2023 •
edited by ghost
Loading

Related: #8143, #8357

Microsoft Reviewers: Open in CodeFlow

@elachlan elachlan requested a review from a team as a code owner February 23, 2023 05:21
@ghost ghost assigned elachlan Feb 23, 2023
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Feb 23, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Feb 23, 2023
@elachlan
Copy link
Contributor Author

@lonitra I think that sorts it.

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Feb 23, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Feb 23, 2023
lonitra
lonitra approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🥳

@lonitra lonitra enabled auto-merge (squash) February 23, 2023 22:34
@lonitra lonitra merged commit 3b6aac5 into dotnet:main Feb 23, 2023
@ghost ghost added this to the 8.0 Preview2 milestone Feb 23, 2023
@elachlan elachlan deleted the StronglyTypedResourceBuilder-Hashtable branch February 23, 2023 22:48
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gpetrou gpetrou gpetrou left review comments

@lonitra lonitra lonitra approved these changes

Assignees

@elachlan elachlan

Labels
None yet
Projects
None yet
Milestone
8.0 Preview2
Development

Successfully merging this pull request may close these issues.
3 participants
@elachlan @gpetrou @lonitra