-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port SelectedPathEditor #2305
Merged
RussKie
merged 1 commit into
release/3.1-uitypeeditors
from
dev/v-vlkres/EditorsPort/SelectedPathEditor
Nov 7, 2019
Merged
Port SelectedPathEditor #2305
RussKie
merged 1 commit into
release/3.1-uitypeeditors
from
dev/v-vlkres/EditorsPort/SelectedPathEditor
Nov 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-krestov
added
the
📬 waiting-for-testing
The PR is awaiting manual testing by the primary team; no action is yet required from the author(s)
label
Nov 6, 2019
Codecov Report
@@ Coverage Diff @@
## release/3.1-uitypeeditors #2305 +/- ##
===================================================================
+ Coverage 26.28007% 26.37082% +0.09075%
===================================================================
Files 830 819 -11
Lines 271860 269730 -2130
Branches 38588 38260 -328
===================================================================
- Hits 71445 71130 -315
+ Misses 195331 193521 -1810
+ Partials 5084 5079 -5
|
RussKie
previously approved these changes
Nov 7, 2019
vladimir-krestov
changed the title
WIP: Porting SelectedPathEditor
Porting SelectedPathEditor
Nov 7, 2019
Fixes issue #2282 Added unit test case Fixed incorrect FolderNameEditor.ShowDialog method
vladimir-krestov
force-pushed
the
dev/v-vlkres/EditorsPort/SelectedPathEditor
branch
from
November 7, 2019 12:01
26f6052
to
72d288c
Compare
Testers approved these changes ✔️ |
vladimir-krestov
removed
the
📬 waiting-for-testing
The PR is awaiting manual testing by the primary team; no action is yet required from the author(s)
label
Nov 7, 2019
We should file a follow up issue that changes the folder picker to the newer one that Oren enabled way back when we first went open source. |
RussKie
pushed a commit
that referenced
this pull request
Nov 8, 2019
ghost
locked as resolved and limited conversation to collaborators
Feb 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2282
Related issue #1115
Proposed changes
SelectedPathEditor
TypeForwardedTo
statement forSelectedPathEditor
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow