Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port SelectedPathEditor #2305

Conversation

vladimir-krestov
Copy link
Contributor

@vladimir-krestov vladimir-krestov commented Nov 6, 2019

Fixes #2282
Related issue #1115

Proposed changes

  • Port SelectedPathEditor
  • Add TypeForwardedTo statement for SelectedPathEditor
  • Make code refactoring
  • Add a unit test case to check SelectedPathEditor

Customer Impact

  • Changed SelectedPath editor to compliance with .Net 4.8.

Regression?

  • Yes

Risk

  • Low

Screenshots

Before

image

After

image

image

Test methodology

  • Manual UI testing
  • CTI
  • Unit testing

Test environment(s)

  • .Net Core version: 3.1.0-preview3.19553.2
  • Microsoft Windows [Version 10.0.18362.418]
Microsoft Reviewers: Open in CodeFlow

@vladimir-krestov vladimir-krestov added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Nov 6, 2019
@vladimir-krestov vladimir-krestov requested a review from a team as a code owner November 6, 2019 19:50
@vladimir-krestov vladimir-krestov self-assigned this Nov 6, 2019
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #2305 into release/3.1-uitypeeditors will increase coverage by 0.09074%.
The diff coverage is 0%.

@@                         Coverage Diff                         @@
##           release/3.1-uitypeeditors       #2305         +/-   ##
===================================================================
+ Coverage                   26.28007%   26.37082%   +0.09075%     
===================================================================
  Files                            830         819         -11     
  Lines                         271860      269730       -2130     
  Branches                       38588       38260        -328     
===================================================================
- Hits                           71445       71130        -315     
+ Misses                        195331      193521       -1810     
+ Partials                        5084        5079          -5
Flag Coverage Δ
#Debug 26.37082% <0%> (+0.09074%) ⬆️
#production 26.37082% <0%> (+0.09074%) ⬆️
#test 100% <ø> (ø) ⬆️

RussKie
RussKie previously approved these changes Nov 7, 2019
@vladimir-krestov vladimir-krestov changed the title WIP: Porting SelectedPathEditor Porting SelectedPathEditor Nov 7, 2019
Fixes issue #2282
Added unit test case
Fixed incorrect FolderNameEditor.ShowDialog method
@vladimir-krestov
Copy link
Contributor Author

Testers approved these changes ✔️

@vladimir-krestov vladimir-krestov removed the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Nov 7, 2019
@merriemcgaw
Copy link
Member

We should file a follow up issue that changes the folder picker to the newer one that Oren enabled way back when we first went open source.

@RussKie RussKie changed the title Porting SelectedPathEditor Port SelectedPathEditor Nov 7, 2019
@RussKie RussKie merged commit 2422f9a into release/3.1-uitypeeditors Nov 7, 2019
@RussKie RussKie deleted the dev/v-vlkres/EditorsPort/SelectedPathEditor branch November 7, 2019 23:13
RussKie pushed a commit that referenced this pull request Nov 8, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants