Fix Color value in PageSettings #13385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inadvertently flipped when changing to CsWin32. Fixes dotnet#13367
Tanya-Solyanik
previously approved these changes
Apr 28, 2025
Tanya-Solyanik
approved these changes
Apr 28, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13385 +/- ##
===================================================
- Coverage 62.63052% 62.62144% -0.00908%
===================================================
Files 1561 1561
Lines 159839 159851 +12
Branches 14915 14916 +1
===================================================
- Hits 100108 100101 -7
- Misses 58955 58974 +19
Partials 776 776
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
/backport to release/9.0 |
Contributor
|
Started backporting to release/9.0: https://github.com/dotnet/winforms/actions/runs/14718863061 |
Tanya-Solyanik
added a commit
that referenced
this pull request
May 8, 2025
Backport of #13385 to release/9.0 /cc @JeremyKuhne ## Customer Impact Reading `PageSettings.Color` gives the wrong value, there is no workaround. ## Testing Regression unit test. ## Risk Low, this was a manual mistake in converting to source generated interop. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/winforms/pull/13389)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inadvertently flipped when changing to CsWin32. Moves helper code for using the PDF printer to write a regression test.
There is no practical workaround for this. If you're looking for whether a printer supports color, however, you can check
PrinterSettings.SupportsColorinstead.Fixes #13367
Microsoft Reviewers: Open in CodeFlow