Refactor and make fixes after code review

* Update ListViewLabelEditAccessibleObject after TextProvider refactoring
* Add new unit tests for constructor arguments

Author: Dmitrii Drobotov

src/System.Windows.Forms.Primitives/src/Interop/User32/Interop.SetWinEventHook.cs

@@ -9,11 +9,11 @@ internal static partial class Interop
     internal static partial class User32
     {
         [DllImport(Libraries.User32, ExactSpelling = true, SetLastError = true)]
-        public static extern nint SetWinEventHook(
-            uint eventMin, uint eventMax, nint hmodWinEventProc, WINEVENTPROC pfnWinEventProc, uint idProcess, uint idThread, WINEVENT dwFlags);
+        private static extern nint SetWinEventHook(uint eventMin, uint eventMax, nint hmodWinEventProc,
+            WINEVENTPROC pfnWinEventProc, uint idProcess, uint idThread, WINEVENT dwFlags);
 
         public static nint SetWinEventHook(uint eventId, WINEVENTPROC pfnWinEventProc)
-            => SetWinEventHook(
-                eventId, eventId, Kernel32.GetModuleHandleW(null), pfnWinEventProc, (uint)Environment.ProcessId, Kernel32.GetCurrentThreadId(), WINEVENT.INCONTEXT);
+            => SetWinEventHook(eventId, eventId, Kernel32.GetModuleHandleW(null), pfnWinEventProc,
+                (uint)Environment.ProcessId, Kernel32.GetCurrentThreadId(), WINEVENT.INCONTEXT);
     }
 }

src/System.Windows.Forms.Primitives/src/Interop/User32/Interop.WINEVENT.cs

@@ -6,7 +6,7 @@ internal static partial class Interop
 {
     internal static partial class User32
     {
-        public enum WINEVENT : int
+        public enum WINEVENT : uint
         {
             OUTOFCONTEXT   = 0,
             SKIPOWNTHREAD  = 1,

src/System.Windows.Forms/src/System/Windows/Forms/ListView.cs

@@ -179,7 +179,7 @@ public partial class ListView : Control
 
         private bool _blockLabelEdit;
 
-        private ListViewLabelEditNativeWindow _labelEdit;
+        private ListViewLabelEditNativeWindow? _labelEdit;
 
         // Background image stuff
         // Because we have to create a temporary file and the OS does not clean up the temporary files from the machine
@@ -6468,9 +6468,12 @@ private unsafe void WmReflectNotify(ref Message m)
 
                 case (int)LVN.BEGINLABELEDITW:
                     {
+                        Debug.Assert(_labelEdit is null,
+                            "A new label editing shouldn't start before the previous one ended");
                         if (_labelEdit is not null)
                         {
-                            throw new InvalidOperationException("A new label editing can't be started before the previous one was ended.");
+                            _labelEdit.ReleaseHandle();
+                            _labelEdit = null;
                         }
 
                         bool cancelEdit;
@@ -6524,9 +6527,10 @@ private unsafe void WmReflectNotify(ref Message m)
 
                 case (int)LVN.ENDLABELEDITW:
                     {
+                        Debug.Assert(_labelEdit is not null, "There is no active label edit to end");
                         if (_labelEdit is null)
                         {
-                            throw new InvalidOperationException("There is no active label edit to end");
+                            break;
                         }
 
                         _labelEdit.ReleaseHandle();

src/System.Windows.Forms/src/System/Windows/Forms/ListViewLabelEditAccessibleObject.cs

@@ -2,7 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using System.Diagnostics;
+using System.Drawing;
 using System.Runtime.InteropServices;
 using static Interop;
 
@@ -12,57 +12,57 @@ internal class ListViewLabelEditAccessibleObject : AccessibleObject
     {
         private const string LIST_VIEW_LABEL_EDIT_AUTOMATION_ID = "1";
 
-        private ListView _owner;
-        private IntPtr _handle;
+        private readonly ListView _owningListView;
+        private readonly IntPtr _handle;
+        private readonly ListViewLabelEditUiaTextProvider _textProvider;
         private int[]? _runtimeId;
 
-        public ListViewLabelEditAccessibleObject(ListView owner, IHandle handle)
+        public ListViewLabelEditAccessibleObject(ListView owningListView, IHandle handle)
         {
-            _owner = owner;
+            _owningListView = owningListView.OrThrowIfNull();
             _handle = handle.Handle;
             UseStdAccessibleObjects(_handle);
+            _textProvider = new ListViewLabelEditUiaTextProvider(owningListView, handle, this);
+        }
+
+        private protected override string AutomationId => LIST_VIEW_LABEL_EDIT_AUTOMATION_ID;
+
+        internal override UiaCore.IRawElementProviderFragment? FragmentNavigate(UiaCore.NavigateDirection direction)
+        {
+            AccessibleObject parent = _owningListView.AccessibilityObject;
 
-            ListViewLabelEditUiaTextProvider textProvider = new(owner, handle, this);
-            UseTextProviders(textProvider, textProvider);
+            return direction switch
+            {
+                UiaCore.NavigateDirection.Parent => parent,
+                UiaCore.NavigateDirection.NextSibling => parent.GetChildIndex(this) is int childId and >= 0 ? parent.GetChild(childId + 1) : null,
+                UiaCore.NavigateDirection.PreviousSibling => parent.GetChildIndex(this) is int childId and >= 0 ? parent.GetChild(childId - 1) : null,
+                _ => base.FragmentNavigate(direction),
+            };
         }
 
+        internal override UiaCore.IRawElementProviderFragmentRoot FragmentRoot => _owningListView.AccessibilityObject;
+
         internal override object? GetPropertyValue(UiaCore.UIA propertyID)
             => propertyID switch
             {
-                UiaCore.UIA.RuntimeIdPropertyId => RuntimeId,
-                UiaCore.UIA.BoundingRectanglePropertyId => Bounds,
                 UiaCore.UIA.ProcessIdPropertyId => Environment.ProcessId,
                 UiaCore.UIA.ControlTypePropertyId => UiaCore.UIA.EditControlTypeId,
-                UiaCore.UIA.NamePropertyId => Name,
                 UiaCore.UIA.AccessKeyPropertyId => string.Empty,
                 UiaCore.UIA.HasKeyboardFocusPropertyId => true,
                 UiaCore.UIA.IsKeyboardFocusablePropertyId => (State & AccessibleStates.Focusable) == AccessibleStates.Focusable,
-                UiaCore.UIA.IsEnabledPropertyId => Enabled,
-                UiaCore.UIA.AutomationIdPropertyId => LIST_VIEW_LABEL_EDIT_AUTOMATION_ID,
-                UiaCore.UIA.HelpTextPropertyId => Help ?? string.Empty,
+                UiaCore.UIA.IsEnabledPropertyId => _owningListView.Enabled,
                 UiaCore.UIA.IsContentElementPropertyId => true,
-                UiaCore.UIA.IsPasswordPropertyId => false,
                 UiaCore.UIA.NativeWindowHandlePropertyId => _handle,
-                UiaCore.UIA.IsOffscreenPropertyId => false,
-                UiaCore.UIA.IsTextPatternAvailablePropertyId => IsPatternSupported(UiaCore.UIA.TextPatternId),
-                UiaCore.UIA.IsTextPattern2AvailablePropertyId => IsPatternSupported(UiaCore.UIA.TextPattern2Id),
-                UiaCore.UIA.IsValuePatternAvailablePropertyId => IsPatternSupported(UiaCore.UIA.ValuePatternId),
-                UiaCore.UIA.IsLegacyIAccessiblePatternAvailablePropertyId => IsPatternSupported(UiaCore.UIA.LegacyIAccessiblePatternId),
                 _ => base.GetPropertyValue(propertyID),
             };
 
-        internal override UiaCore.IRawElementProviderFragment? FragmentNavigate(UiaCore.NavigateDirection direction)
+        internal override UiaCore.IRawElementProviderSimple? HostRawElementProvider
         {
-            AccessibleObject parent = _owner.AccessibilityObject;
-
-            return direction switch
+            get
             {
-                UiaCore.NavigateDirection.Parent => parent,
-                UiaCore.NavigateDirection.NextSibling => parent.GetChildIndex(this) is int childId and >= 0 ? parent.GetChild(childId + 1) : null,
-                UiaCore.NavigateDirection.PreviousSibling => parent.GetChildIndex(this) is int childId and >= 0 ? parent.GetChild(childId - 1) : null,
-                UiaCore.NavigateDirection.FirstChild or UiaCore.NavigateDirection.LastChild => null,
-                _ => base.FragmentNavigate(direction),
-            };
+                UiaCore.UiaHostProviderFromHwnd(new HandleRef(this, _handle), out UiaCore.IRawElementProviderSimple provider);
+                return provider;
+            }
         }
 
         internal override bool IsPatternSupported(UiaCore.UIA patternId) => patternId switch
@@ -74,28 +74,32 @@ public ListViewLabelEditAccessibleObject(ListView owner, IHandle handle)
             _ => base.IsPatternSupported(patternId),
         };
 
+        public override string Name => User32.GetWindowText(_handle);
+
         internal override int[] RuntimeId => _runtimeId ??= new int[] { RuntimeIDFirstItem, PARAM.ToInt(_handle) };
 
-        internal override UiaCore.IRawElementProviderFragmentRoot? FragmentRoot => _owner.AccessibilityObject;
+        internal override UiaCore.ITextRangeProvider DocumentRangeInternal
+            => _textProvider.DocumentRange;
 
-        internal override UiaCore.IRawElementProviderSimple? HostRawElementProvider
-        {
-            get
-            {
-                UiaCore.UiaHostProviderFromHwnd(new HandleRef(this, _handle), out UiaCore.IRawElementProviderSimple provider);
-                return provider;
-            }
-        }
+        internal override UiaCore.ITextRangeProvider[]? GetTextSelection()
+            => _textProvider.GetSelection();
 
-        public override string Name => User32.GetWindowText(_handle);
+        internal override UiaCore.ITextRangeProvider[]? GetTextVisibleRanges()
+            => _textProvider.GetVisibleRanges();
 
-        private bool Enabled
-        {
-            get
-            {
-                Debug.Assert(_owner.Enabled);
-                return _owner.Enabled;
-            }
-        }
+        internal override UiaCore.ITextRangeProvider? GetTextRangeFromChild(UiaCore.IRawElementProviderSimple childElement)
+            => _textProvider.RangeFromChild(childElement);
+
+        internal override UiaCore.ITextRangeProvider? GetTextRangeFromPoint(Point screenLocation)
+            => _textProvider.RangeFromPoint(screenLocation);
+
+        internal override UiaCore.SupportedTextSelection SupportedTextSelectionInternal
+            => _textProvider.SupportedTextSelection;
+
+        internal override UiaCore.ITextRangeProvider? GetTextCaretRange(out BOOL isActive)
+            => _textProvider.GetCaretRange(out isActive);
+
+        internal override UiaCore.ITextRangeProvider GetRangeFromAnnotation(UiaCore.IRawElementProviderSimple annotationElement)
+            => _textProvider.RangeFromAnnotation(annotationElement);
     }
 }