Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Expressions to generate InvokeDelegate #5298

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Use Expressions to generate InvokeDelegate #5298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c5694b
Use Expressions to generate InvokeDelegate
g7ed6e Sep 26, 2023
6bdeea1
Remove unnecessary cast
g7ed6e Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 110 additions & 0 deletions src/System.ServiceModel.Primitives/src/System/ServiceModel/Dispatcher/InvokerUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,27 @@


using System.Collections.Generic;
using System.Linq.Expressions;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Runtime.ExceptionServices;
using System.ServiceModel.Description;
using System.Text;

namespace System.ServiceModel.Dispatcher
{
internal delegate object InvokeDelegate(object target, object[] inputs, object[] outputs);

internal sealed class InvokerUtil
{
private static readonly string s_useLegacyInvokeDelegateAppContextSwitchKey = "System.ServiceModel.Dispatcher.UseLegacyInvokeDelegate";

private static readonly Lazy<bool> s_useLegacyInvokeDelegate = new Lazy<bool>(() =>
AppContext.TryGetSwitch(s_useLegacyInvokeDelegateAppContextSwitchKey, out bool useLegacyInvokeDelegate)
? useLegacyInvokeDelegate
: false
);

private readonly CriticalHelper _helper;

public InvokerUtil()
Expand All @@ -23,6 +35,11 @@ public InvokerUtil()
internal InvokeDelegate GenerateInvokeDelegate(MethodInfo method, out int inputParameterCount,
out int outputParameterCount)
{
if (!s_useLegacyInvokeDelegate.Value && RuntimeFeature.IsDynamicCodeSupported)
{
return _helper.GenerateInvokeDelegateInternalWithExpressions(method, out inputParameterCount, out outputParameterCount);
}

return _helper.GenerateInvokeDelegate(method, out inputParameterCount, out outputParameterCount);
}

Expand Down Expand Up @@ -85,6 +102,99 @@ internal InvokeDelegate GenerateInvokeDelegate(MethodInfo method, out int inputP

return lambda;
}

internal InvokeDelegate GenerateInvokeDelegateInternalWithExpressions(MethodInfo method, out int inputParameterCount, out int outputParameterCount)
{
inputParameterCount = 0;
outputParameterCount = 0;
ParameterInfo[] parameters = method.GetParameters();
bool returnsValue = method.ReturnType != typeof(void);
bool returnsValueType = method.ReturnType.IsValueType;

var targetParam = Expression.Parameter(typeof(object), "target");
var inputsParam = Expression.Parameter(typeof(object[]), "inputs");
var outputsParam = Expression.Parameter(typeof(object[]), "outputs");

List<ParameterExpression> variables = new();
var result = Expression.Variable(typeof(object), "result");
variables.Add(result);

List<(Type ParameterType, ParameterExpression OutputExpression)> outputVariables = new();
List<ParameterExpression> invocationParameters = new();
List<Expression> expressions = new();

for (int i = 0; i < parameters.Length; i++)
{
Type variableType = parameters[i].ParameterType.IsByRef
? parameters[i].ParameterType.GetElementType()
: parameters[i].ParameterType;
ParameterExpression variable = Expression.Variable(variableType, $"p{i}");

if (ServiceReflector.FlowsIn(parameters[i]))
{
expressions.Add(Expression.Assign(variable, Expression.Convert(Expression.ArrayIndex(inputsParam, Expression.Constant(inputParameterCount)), variableType)));
inputParameterCount++;
}

if (ServiceReflector.FlowsOut(parameters[i]))
{
outputParameterCount++;
outputVariables.Add((variableType, variable));
}

variables.Add(variable);
invocationParameters.Add(variable);
}

var castTargetParam = Expression.Convert(targetParam, method.DeclaringType);

if (returnsValue)
{
if (returnsValueType)
{
expressions.Add(Expression.Assign(result, Expression.Convert(Expression.Call(castTargetParam, method, invocationParameters), typeof(object))));
}
else
{
expressions.Add(Expression.Assign(result, Expression.Call(castTargetParam, method, invocationParameters)));
}
}
else
{
expressions.Add(Expression.Call(castTargetParam, method, invocationParameters));
expressions.Add(Expression.Assign(result, Expression.Constant(null, typeof(object))));
}

int j = 0;
foreach (var outputVariable in outputVariables)
{
if (outputVariable.ParameterType.IsValueType)
{
expressions.Add(Expression.Assign(
Expression.ArrayAccess(outputsParam, Expression.Constant(j)),
Expression.Convert(outputVariable.OutputExpression, typeof(object))));
}
else
{
expressions.Add(Expression.Assign(
Expression.ArrayAccess(outputsParam, Expression.Constant(j)),
outputVariable.OutputExpression));
}
j++;
}

expressions.Add(result);

BlockExpression finalBlock = Expression.Block(variables: variables, expressions: expressions);

Expression<InvokeDelegate> lambda = Expression.Lambda<InvokeDelegate>(
finalBlock,
targetParam,
inputsParam,
outputsParam);

return lambda.Compile();
}
}
}
}