Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic restore is slow when there are many un-restored projects #6737

Open
dibarbet opened this issue Dec 11, 2023 · 0 comments
Open

Automatic restore is slow when there are many un-restored projects #6737

dibarbet opened this issue Dec 11, 2023 · 0 comments
Assignees
Milestone

Comments

@dibarbet
Copy link
Member

The basic problem is that currently the server shells out to the CLI once per project - https://github.com/dotnet/roslyn/blob/main/src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/LanguageServer/Handler/Restore/RestoreHandler.cs#L50

This can be quite a lot slower than restoring the entire solution in large solutions (for example Roslyn.sln).

Some potential improvements

  1. See if it is possible to restore multiple projects at once via a single dotnet CLI command
  2. Detect on the server side if there are many projects needing a restore, and use the solution path instead (if there is one available).
@dibarbet dibarbet added this to the December2023 milestone Dec 11, 2023
@dibarbet dibarbet self-assigned this Dec 11, 2023
@dibarbet dibarbet changed the title Automatic restore is slow when there are many un-restored projects in the solution Automatic restore is slow when there are many un-restored projects Dec 11, 2023
@dibarbet dibarbet modified the milestones: December2023, Backlog May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant