Skip to content

Surface addtextextension setting in TemplateVerifierOptions #5785

Open

Description

Is your feature request related to a problem? Please describe.

TemplateVerifier performs binary stream comparison of files with unrecognized or no extensions. Textual comparison is preferable in cases where content is text (due to normalization of newlines, byte order marks, etc.)

Describe the solution you'd like.

There is an option in Verify to tag file extension as textual: https://github.com/VerifyTests/EmptyFiles#addtextextension, the content verification then will work as on text (same as for well recognized textual extensions)

This should be surfaced via TemplateVerifierOptions (e.g. as AdditionalTextExtensions) and then passed to Verify.

Additionally the special case noextension extension should be allways implicitly added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Priority:3Work that is nice to havearea: authoring toolsRelated to authoring toolsgood first issueeasy issue, good for first-time contribution to the repotriagedThe issue was evaluated by the triage team, placed on correct area, next action defined.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions