Skip to content

Improve error message on invalid template parameters in Edge.TemplateCreator #4225

Open

Description

This is a refactoring task that can be done after new parser is implemented.

Applicable to two creation results:
MissingMandatoryParam, InvalidParamValues.

Both of these cases are caused by invalid parameters passed to TemplateCreator on template creation.
The error message returned by TemplateCreator in those cases is poor:

  • for MissingMandatoryParam it is a comma-separated list of missing parameters
  • similar to InvalidParamValues

Due to this, TemplateInvoker in CLI has weird logic of parsing those messages, as it needs to show errors about options, and not parameter names.

Consider improving ITemplateCreationResult for these statuses. As example, it may contain dictionary with parameters and localized error message, then TemplateInvoker can use it to show error message vs template options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Priority:2Work that is important, but not critical for the releasearea: apiRelated to public API changes/bugsarea: refactoringThe technical improvement/refactoringgood first issueeasy issue, good for first-time contribution to the repotriagedThe issue was evaluated by the triage team, placed on correct area, next action defined.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions