Merge | Align TdsExecuteRPC between netcore and netfx #3292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardneal
reviewed
Apr 23, 2025
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
…t/TdsParser.cs Simplify a if statement where they're the same regardless of true/false Co-authored-by: Edward Neal <55035479+edwardneal@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
==========================================
+ Coverage 72.98% 73.03% +0.04%
==========================================
Files 299 298 -1
Lines 57215 57033 -182
==========================================
- Hits 41760 41653 -107
+ Misses 15455 15380 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samsharma2700
approved these changes
Apr 29, 2025
apoorvdeshmukh
approved these changes
Apr 29, 2025
cheenamalhotra
approved these changes
Apr 29, 2025
samsharma2700
approved these changes
Apr 29, 2025
This was referenced Jul 25, 2025
Open
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreation of #2985 to resolve merge conflicts and get full CI runs
Splitting up TdsExecuteRPC to multiple functions to align netcore and netfx
Part of #2953