-
Couldn't load subscription status.
- Fork 316
Merge | LocalDbConfig #3171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge | LocalDbConfig #3171
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
==========================================
- Coverage 72.96% 72.79% -0.18%
==========================================
Files 283 284 +1
Lines 58997 59110 +113
==========================================
- Hits 43048 43029 -19
- Misses 15949 16081 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description: Finally back on track for merging the netfx and netcore projects. In this exciting installment, we're merging the LocalDbConfig file. This file contains a few class definitions that are used to provide an object model for accessing the program's configuration file. They only apply to netfx, and can be easily moved into the common project, tagged as netfx, and wrapped in
#if NETFRAMEWORK. The file was also split into separate files for class and placed in a folder that better represents the namespace (Microsoft.Data.SqlClient.LocalDb).Testing: No functional changes, just moving things around.