Tests | Split MultipleResultsTest, clean up console logging#3060
Tests | Split MultipleResultsTest, clean up console logging#3060benrr101 merged 8 commits intodotnet:mainfrom
Conversation
Also adjusted certificate generation, it's redirecting standard errors and not always loading the user profile.
| @@ -76,7 +76,6 @@ public void CustomActiveDirectoryProviderTest_AppClientId_DeviceFlowCallback() | |||
|
|
|||
| private Task CustomDeviceFlowCallback(DeviceCodeResult result) | |||
There was a problem hiding this comment.
It would help readability if we remove this method. It's not doing anything useful now that the logging is removed.
There was a problem hiding this comment.
Thanks, I've removed it. Can you trigger another CI run please?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
- Coverage 72.81% 66.21% -6.61%
==========================================
Files 282 276 -6
Lines 59112 58802 -310
==========================================
- Hits 43045 38933 -4112
- Misses 16067 19869 +3802
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benrr101
left a comment
There was a problem hiding this comment.
This is awesome, I love anything that breaks up complicated tests and cleans up the console output on the tests. 🚀
Would love to see the few comments I made addressed, but I also won't hold things up if you don't want to address them.
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs
Outdated
Show resolved
Hide resolved
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs
Outdated
Show resolved
Hide resolved
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This starts to adjust the way the SqlClient tests use the console stdout. It contains two changes.
MultipleResultsTest rework
This was one large method. It would temporarily replace the console stdout, log to it, then manually perform a diff between the stdout and a file bundled with the project.
I've modified this, splitting the large method into three tests (ExecuteNonQuery, ExecuteReader, ExecuteScalar.) These tests are designed to prove the way that SqlClient handles informational messages, exceptions and result sets when MARS is enabled.
Console stdout rework
I've noticed a few instances where standard output from the TDS servers get mixed in with the test results logged in the CI pipeline. This output isn't useful, even when the tests fail; I've disabled it in a few areas.