Tests | Fix SqlBatch Test Deadlocks

[MichelZ]

AI Blurp

This pull request includes changes to the BatchTests.cs file to add retry logic for SQL commands and to enhance the SqlBatchCommand functionality. The most important changes are as follows:

Enhancements to SQL retry logic:

• Added retry logic configuration using SqlRetryLogicOption and SqlRetryLogicBaseProvider to handle transient errors like deadlocks by retrying the operation up to three times with a delay of 100 milliseconds.

Improvements to SqlBatchCommand:

• Modified StoredProcedureBatchSupported and MixedBatchSupported methods to include parameters in SqlBatchCommand for executing stored procedures, specifically adding a parameter for the sp_help stored procedure.

Additional imports:

• Added System.Collections.Generic import to support the use of List<SqlParameter> in the updated methods.

Description

I regularly see deadlocks for the tests that use sp_help.
I'll try to mitigate this in 2 different ways:

• Add a retry for ErrorNumber 1205 (Deadlock)
• Add a parameter @objname that does less work so it's less likely to get a deadlock

It can probably also be solved by just using another stored procedure that's not prone to deadlocks, but I chose this way as the easiest path

Example test failure:
https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=101959&view=logs&j=700ebecb-e440-5400-66bb-488206e790af&t=d8ae6a68-b967-5b1e-ef3d-1b53d82075ee&l=826

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.78%. Comparing base (b1f7eaf) to head (4ab317f).
Report is 85 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
+ Coverage   72.68%   72.78%   +0.09%     
==========================================
  Files         285      332      +47     
  Lines       59155    83162   +24007     
==========================================
+ Hits        42998    60530   +17532     
- Misses      16157    22632    +6475     

Flag	Coverage Δ
addons	92.58% <ø> (ø)
netcore	74.50% <ø> (-0.89%)	⬇️
netfx	71.76% <ø> (+0.63%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).