Merge | Align Type aliases between netfx and netcore#2957
Merge | Align Type aliases between netfx and netcore#2957benrr101 merged 5 commits intodotnet:mainfrom
Conversation
benrr101
left a comment
There was a problem hiding this comment.
Looks good, but going forward, I think we can combine a couple of PRs like this together. I'm starting to get fatigue from reviewing these all independently 😅
Apologies, I really thought it makes it easier for review to have smaller, more targeted PR's... Guess I was wrong :) |
|
There's definitely a balance :) I think we'll still take stuff when it's bite-sized like this, but it just might be slow with all the overhead. On the other hand, gigantic PRs are a lot more likely to just be outright rejected |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
===========================================
- Coverage 92.58% 73.18% -19.40%
===========================================
Files 6 288 +282
Lines 310 65607 +65297
===========================================
+ Hits 287 48014 +47727
- Misses 23 17593 +17570
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mdaigle
left a comment
There was a problem hiding this comment.
Looks good after merge conflicts are fixed
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
AZP needs a smack on the head |
f335f1b to
36fd740
Compare
|
@cheenamalhotra Anything I can do to move this along? Thx |
Requested change has been addressed
This PR solely aligns type aliases between netfx and netcore versions so they can be merged easier later.
Part of #2953