Enable Source Link in design-time build (#1144)

Author: tmat

gitc

@@ -7,14 +7,13 @@
 
   <PropertyGroup>
     <!--
-      Do not query source control manager for any information when building in the IDE or for Live Unit Testing.
-      Features that need this information will be disabled if false.
+      Used to suppress querying source control and features that use the information (e.g. git commit SHA).
     -->
-    <EnableSourceControlManagerQueries Condition="'$(EnableSourceControlManagerQueries)' == '' and '$(DesignTimeBuild)' != 'true' and '$(BuildingForLiveUnitTesting)' != 'true'">true</EnableSourceControlManagerQueries>
-    
+    <EnableSourceControlManagerQueries Condition="'$(EnableSourceControlManagerQueries)' == ''">true</EnableSourceControlManagerQueries>
+
     <!--
       Do not generate SourceLink when building in the IDE or for Live Unit Testing.
     -->
     <EnableSourceLink Condition="'$(EnableSourceLink)' == '' and '$(DesignTimeBuild)' != 'true' and '$(BuildingForLiveUnitTesting)' != 'true'">true</EnableSourceLink>
-  </PropertyGroup>  
+  </PropertyGroup>
 </Project>

src/SourceLink.Common/build/Microsoft.SourceLink.Common.props

@@ -14,11 +14,14 @@
     Triggers SetEmbeddedFilesFromSourceControlManagerUntrackedFiles target defined by a source control package Microsoft.Build.Tasks.{Git|Tfvc|...}.
     Assumes that all targets that generate source files and add them to Compile items run before BeforeCompile target.
     This is a convention established by common targets.
+    
+    Disabled for design-time build since calculating untracked files is non-trivial operation
+    and embedding them only affects the content of the generated PDB, which has no impact on design-time build.
   -->
   <Target Name="_SetEmbeddedFilesFromSourceControlManagerUntrackedFiles"
           DependsOnTargets="BeforeCompile;SetEmbeddedFilesFromSourceControlManagerUntrackedFiles"
           BeforeTargets="CoreCompile"
-          Condition="'$(EmbedUntrackedSources)' == 'true' and '$(EmbedAllSources)' != 'true' and '$(DebugType)' != 'none' and '$(EnableSourceControlManagerQueries)' == 'true'" />
+          Condition="'$(EmbedUntrackedSources)' == 'true' and '$(EmbedAllSources)' != 'true' and '$(DebugType)' != 'none' and '$(EnableSourceControlManagerQueries)' == 'true' and '$(DesignTimeBuild)' != 'true'" />
 
   <!--
     If defined populates MappedPath metadata of SourceRoot items.

src/SourceLink.Common/build/Microsoft.SourceLink.Common.targets

@@ -90,7 +90,8 @@ public void DefaultValuesForEnableProperties_DesignTimeBuild()
                 expectedResults: new[]
                 {
                     NuGetPackageFolders,
-                    "",
+                    ProjectSourceRoot,
+                    "true",
                     "",
                     ""
                 },
@@ -125,7 +126,8 @@ public void DefaultValuesForEnableProperties_BuildingForLiveUnitTesting()
                 expectedResults: new[]
                 {
                     NuGetPackageFolders,
-                    "",
+                    ProjectSourceRoot,
+                    "true",
                     "",
                     ""
                 },