Update to the April 3.1.14 release #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MichaelSimons
approved these changes
Apr 14, 2021
omajid
reviewed
Apr 16, 2021
| </ItemGroup> | ||
| <!-- Also copy to the legacy path without the architecture for SBRP for now --> | ||
| <Copy SourceFiles="@(CoreClrToolsFiles)" DestinationFolder="$(SourceBuiltPackagesPath)coreclr-tools" /> | ||
| <Copy SourceFiles="@(CoreClrToolsFiles)" DestinationFolder="$(SourceBuiltPackagesPath)coreclr-tools/$(BuildArchitecture)" /> |
Member
There was a problem hiding this comment.
I wonder if it would be better to always use the architecture-less path.
When we use /usr/bin/clang we dont worry whether that's for x86-64 or aarch64, we just assume it's for this architecture. Same for /usr/bin/dotnet, we don't check what architecture that's for. We just use it.
Along the same line, shouldn't we assume $(SourceBuiltPackagesPath)coreclr-tools is the right set of tools for this architecture?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.