Skip to content

Conversation

@edvilme
Copy link
Contributor

@edvilme edvilme commented Mar 5, 2025

Description

Updates vs-solutionpersistence to new release v.1.0.52 with several bug fixes and improvements.

dotnet/sdk#47297

PR Checklist

If you are upgrading the version of a repo submodule, please follow this
checklist:

  • Provide a link to an issue in the consuming repo describing the need for
    the upgrade. Both this PR and the PR doing the upgrade in the consuming repo
    should link to that issue.
  • Have you done your due diligence to ensure the upgrade can be completed
    in the consuming repo in a timely manner? If consuming the dependency flow of
    this update takes a long time or needs to be backed out, it may require the
    reversion of the upgrade in this PR. That's something we want to avoid.
  • When consuming the dependency flow from this repo for the purposes of a
    version upgrade, consider using a separate PR or at least changing the title of
    the dependency flow PR to accurately reflect the purpose of the change. Seeing
    a PR named "Upgrade IdentityModel to 8.0.1", for example, provides better
    clarity than "Update dependencies from dotnet/source-build-externals".

@edvilme edvilme force-pushed the vs-solutionpersistence branch from bdba326 to 51e09aa Compare March 5, 2025 18:25
@edvilme edvilme marked this pull request as ready for review March 5, 2025 20:16
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide this info from the PR template:

Provide a link to an issue in the consuming repo describing the need for
the upgrade. Both this PR and the PR doing the upgrade in the consuming repo
should link to that issue.

@edvilme
Copy link
Contributor Author

edvilme commented Mar 6, 2025

Hi @mthalman I updated the description with links to the release and the PRs in the release. Please let me know if that works :)

@kasperk81
Copy link
Contributor

they are asking for links in cosumer repos, like sdk and msbuild, not the source repo

@mthalman
Copy link
Member

mthalman commented Mar 6, 2025

they are asking for links in cosumer repos, like sdk and msbuild, not the source repo

correct

@edvilme edvilme requested a review from mthalman March 6, 2025 21:02
@mthalman mthalman merged commit 148cf3e into dotnet:main Mar 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants